Conversation
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
| # "Department of Labor": "https://www.dol.gov/code.json", | ||
| # "Department of Transportation": "https://www.transportation.gov/code.json", | ||
| "DoT": "https://www.treasury.gov/code.json", | ||
| "TREASURY": "https://www.treasury.gov/code.json", |
There was a problem hiding this comment.
Updated agency names to match acronyms list in the original code-gov implementation: https://github.com/GSA/code-gov-data/blob/master/agency_metadata.json
IDEA: I think we should separate out this agency metadata to its own file like how it is done there. I can forsee the frontend also needing to use this data
There was a problem hiding this comment.
IDEA for later: Building on top of this, we should display the agency's full name in the agency cards for users that do not know the acronyms. We can use the separate agency metadata file to make this happen @DinneK
| # the commented out links are not valid or cant be found | ||
| agencies_links = { | ||
| "DoA": "https://usda.gov/code.json", | ||
| "USDA": "https://usda.gov/code.json", |
There was a problem hiding this comment.
Because I made this change, we'll need to rerun the scripts. I'll message you guys tmr for your help @sachin-panayil @IsaacMilarky
There was a problem hiding this comment.
Instead, decided to run the scripts using GitHub Action after merging this PR
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
2 participants
Agencies: Added agency logos
Problem
We would like to add agency logos to our agency cards. Currently, we have an emoji as a placeholder.
Solution
Using the images in
agency_logodirectory, added image to agency card.agency.codeshould match with agency logo title (example: usda -> usda.png)Result
Each agency card now has their logo shown at the top right!
Test Plan
Tests passed,
npm run dev